diff options
| author | Frederic Barrat | 2021-11-16 18:01:33 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin | 2022-01-07 11:19:55 +0100 |
| commit | 20766514d602c50b870ae943aaa8e5b9e2e8a161 (patch) | |
| tree | cbef27c0cf2691f984ef350e3811bf33e114089a /hw/pci | |
| parent | pci: Export the pci_intx() function (diff) | |
| download | qemu-20766514d602c50b870ae943aaa8e5b9e2e8a161.tar.gz qemu-20766514d602c50b870ae943aaa8e5b9e2e8a161.tar.xz qemu-20766514d602c50b870ae943aaa8e5b9e2e8a161.zip | |
pcie_aer: Don't trigger a LSI if none are defined
Skip triggering an LSI when the AER root error status is updated if no
LSI is defined for the device. We can have a root bridge with no LSI,
MSI and MSI-X defined, for example on POWER systems.
Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
Message-Id: <20211116170133.724751-4-fbarrat@linux.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Diffstat (limited to 'hw/pci')
| -rw-r--r-- | hw/pci/pcie_aer.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c index 27f9cc56af..e1a8a88c8c 100644 --- a/hw/pci/pcie_aer.c +++ b/hw/pci/pcie_aer.c @@ -774,7 +774,9 @@ void pcie_aer_root_write_config(PCIDevice *dev, uint32_t root_cmd = pci_get_long(aer_cap + PCI_ERR_ROOT_COMMAND); /* 6.2.4.1.2 Interrupt Generation */ if (!msix_enabled(dev) && !msi_enabled(dev)) { - pci_set_irq(dev, !!(root_cmd & enabled_cmd)); + if (pci_intx(dev) != -1) { + pci_set_irq(dev, !!(root_cmd & enabled_cmd)); + } return; } |