diff options
| author | Cao jin | 2016-06-10 11:54:22 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin | 2016-06-17 02:28:03 +0200 |
| commit | 97fe42f19b989ecfd0c6a23b9c09dbc7159c7602 (patch) | |
| tree | 4f4cccd747d84fa5ae7d212646b53f5b73a9bf06 /hw/pci | |
| parent | test: start vhost-user reconnect test (diff) | |
| download | qemu-97fe42f19b989ecfd0c6a23b9c09dbc7159c7602.tar.gz qemu-97fe42f19b989ecfd0c6a23b9c09dbc7159c7602.tar.xz qemu-97fe42f19b989ecfd0c6a23b9c09dbc7159c7602.zip | |
pci core: assert ENOSPC when add capability
ENOSPC is programming error, assert it for debugging.
cc: Michael S. Tsirkin <mst@redhat.com>
cc: Marcel Apfelbaum <marcel@redhat.com>
cc: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/pci')
| -rw-r--r-- | hw/pci/pci.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 87bea47e85..4b585f47b6 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -2228,10 +2228,8 @@ int pci_add_capability2(PCIDevice *pdev, uint8_t cap_id, if (!offset) { offset = pci_find_space(pdev, size); - if (!offset) { - error_setg(errp, "out of PCI config space"); - return -ENOSPC; - } + /* out of PCI config space is programming error */ + assert(offset); } else { /* Verify that capabilities don't overlap. Note: device assignment * depends on this check to verify that the device is not broken. |