diff options
| author | Alexey Kardashevskiy | 2017-10-19 04:15:05 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin | 2017-11-16 16:46:53 +0100 |
| commit | d06bce95ff8c6e2f290db150695f826c3d57324f (patch) | |
| tree | 4f361d5c2a12a8c5a6f30e5fcd38d96cc00a9647 /hw/pci | |
| parent | fix: unrealize virtio device if we fail to hotplug it (diff) | |
| download | qemu-d06bce95ff8c6e2f290db150695f826c3d57324f.tar.gz qemu-d06bce95ff8c6e2f290db150695f826c3d57324f.tar.xz qemu-d06bce95ff8c6e2f290db150695f826c3d57324f.zip | |
pci: Initialize pci_dev->name before use
This moves pci_dev->name initialization earlier so
pci_dev->bus_master_as could get a name instead of an empty string.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/pci')
| -rw-r--r-- | hw/pci/pci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 5ed3c8dca4..b2d139bd9a 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1030,6 +1030,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus, pci_dev->devfn = devfn; pci_dev->requester_id_cache = pci_req_id_cache_get(pci_dev); + pstrcpy(pci_dev->name, sizeof(pci_dev->name), name); memory_region_init(&pci_dev->bus_master_container_region, OBJECT(pci_dev), "bus master container", UINT64_MAX); @@ -1039,7 +1040,6 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus, if (qdev_hotplug) { pci_init_bus_master(pci_dev); } - pstrcpy(pci_dev->name, sizeof(pci_dev->name), name); pci_dev->irq_state = 0; pci_config_alloc(pci_dev); |