diff options
| author | Greg Kurz | 2020-12-24 18:22:47 +0100 |
|---|---|---|
| committer | David Gibson | 2021-01-06 01:09:59 +0100 |
| commit | b040e591c5cf116b8a51821db0de09213530c689 (patch) | |
| tree | ad77c50dc68baf82da21fe18cac3f9faeaee3e3d /hw/ppc/Kconfig | |
| parent | spapr: Add drc_ prefix to the DRC realize and unrealize functions (diff) | |
| download | qemu-b040e591c5cf116b8a51821db0de09213530c689.tar.gz qemu-b040e591c5cf116b8a51821db0de09213530c689.tar.xz qemu-b040e591c5cf116b8a51821db0de09213530c689.zip | |
ppc: Fix build with --without-default-devices
Linking of the qemu-system-ppc64 fails on a POWER9 host when
--without-default-devices is passed to configure:
$ ./configure --without-default-devices \
--target-list=ppc64-softmmu && make
...
libqemu-ppc64-softmmu.fa.p/hw_ppc_e500.c.o: In function `ppce500_init_mpic_kvm':
/home/greg/Work/qemu/qemu-ppc/build/../hw/ppc/e500.c:777: undefined reference to `kvm_openpic_connect_vcpu'
libqemu-ppc64-softmmu.fa.p/hw_ppc_spapr_irq.c.o: In function `spapr_irq_check':
/home/greg/Work/qemu/qemu-ppc/build/../hw/ppc/spapr_irq.c:189: undefined reference to `xics_kvm_has_broken_disconnect'
libqemu-ppc64-softmmu.fa.p/hw_intc_spapr_xive.c.o: In function `spapr_xive_post_load':
/home/greg/Work/qemu/qemu-ppc/build/../hw/intc/spapr_xive.c:530: undefined reference to `kvmppc_xive_post_load'
... and tons of other symbols belonging to the KVM backend of the
openpic, XICS and XIVE interrupt controllers.
It turns out that OPENPIC_KVM, XICS_KVM and XIVE_KVM are marked
to depend on KVM but this has no effect when minikconf runs in
allnoconfig mode. Such reverse dependencies should rather be
handled with a 'select' statement, eg.
config OPENPIC
select OPENPIC_KVM if KVM
or even better by getting rid of the intermediate _KVM config
and directly checking CONFIG_KVM in the meson.build file:
specific_ss.add(when: ['CONFIG_KVM', 'CONFIG_OPENPIC'],
if_true: files('openpic_kvm.c'))
Go for the latter with OPENPIC, XICS and XIVE.
This went unnoticed so far because CI doesn't test the build with
--without-default-devices and KVM enabled on a POWER host.
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <160883056791.253005.14924294027763955653.stgit@bahia.lan>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/ppc/Kconfig')
| -rw-r--r-- | hw/ppc/Kconfig | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index 982d55f587..e35710c7c3 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -139,11 +139,6 @@ config XIVE_SPAPR depends on PSERIES select XIVE -config XIVE_KVM - bool - default y - depends on XIVE_SPAPR && KVM - # Only used by 64-bit targets config FW_CFG_PPC bool |