diff options
| author | Chen Qun | 2020-11-16 03:48:09 +0100 |
|---|---|---|
| committer | David Gibson | 2020-12-14 05:50:55 +0100 |
| commit | b2bd5b20fd1854cdbfee87553855163081a6c531 (patch) | |
| tree | ce87dee11b766a7cdd5c77932980b1976aed06dd /hw/ppc/ppc.c | |
| parent | target/ppc: replaced the TODO with LOG_UNIMP and add break for silence warnings (diff) | |
| download | qemu-b2bd5b20fd1854cdbfee87553855163081a6c531.tar.gz qemu-b2bd5b20fd1854cdbfee87553855163081a6c531.tar.xz qemu-b2bd5b20fd1854cdbfee87553855163081a6c531.zip | |
ppc: Add a missing break for PPC6xx_INPUT_TBEN
When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
hw/ppc/ppc.c: In function ‘ppc6xx_set_irq’:
hw/ppc/ppc.c:118:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
118 | if (level) {
| ^
hw/ppc/ppc.c:123:9: note: here
123 | case PPC6xx_INPUT_INT:
| ^~~~
According to the discussion, a break statement needs to be added here.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20201116024810.2415819-7-kuhn.chenqun@huawei.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/ppc/ppc.c')
| -rw-r--r-- | hw/ppc/ppc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index 4a11fb1640..1b98272076 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -120,6 +120,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int level) } else { cpu_ppc_tb_stop(env); } + break; case PPC6xx_INPUT_INT: /* Level sensitive - active high */ LOG_IRQ("%s: set the external IRQ state to %d\n", |