diff options
| author | David Gibson | 2017-12-08 04:11:49 +0100 |
|---|---|---|
| committer | David Gibson | 2017-12-14 23:49:24 +0100 |
| commit | 4f441474c61f317de7927edfdb1d042b0b6f3882 (patch) | |
| tree | 3ddcfc0f0b6a8748c5b891f3033be2bfa27256ff /hw/ppc/spapr.c | |
| parent | spapr: Rename machine init functions for clarity (diff) | |
| download | qemu-4f441474c61f317de7927edfdb1d042b0b6f3882.tar.gz qemu-4f441474c61f317de7927edfdb1d042b0b6f3882.tar.xz qemu-4f441474c61f317de7927edfdb1d042b0b6f3882.zip | |
spapr: Assume msi_nonbroken
We conditionally adjust part of the guest device tree based on the
global msi_nonbroken flag. However, the main machine type code
initializes msi_nonbroken to true and there's nothing that would set
it to false again.
So replace the test with an assert().
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Diffstat (limited to 'hw/ppc/spapr.c')
| -rw-r--r-- | hw/ppc/spapr.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 42d6a2302a..4f354a8760 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -943,9 +943,8 @@ static void spapr_dt_rtas(sPAPRMachineState *spapr, void *fdt) _FDT(fdt_setprop_cell(fdt, rtas, "rtas-event-scan-rate", RTAS_EVENT_SCAN_RATE)); - if (msi_nonbroken) { - _FDT(fdt_setprop(fdt, rtas, "ibm,change-msix-capable", NULL, 0)); - } + g_assert(msi_nonbroken); + _FDT(fdt_setprop(fdt, rtas, "ibm,change-msix-capable", NULL, 0)); /* * According to PAPR, rtas ibm,os-term does not guarantee a return |