diff options
| author | Greg Kurz | 2020-10-12 13:26:39 +0200 |
|---|---|---|
| committer | David Gibson | 2020-10-27 15:08:53 +0100 |
| commit | eaf1ffbe15fe67612c63d928415ee04eb4836dc7 (patch) | |
| tree | e727c50f92c59243572add902b3bdace9503e7a4 /hw/ppc/spapr_drc.c | |
| parent | Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20201026a'... (diff) | |
| download | qemu-eaf1ffbe15fe67612c63d928415ee04eb4836dc7.tar.gz qemu-eaf1ffbe15fe67612c63d928415ee04eb4836dc7.tar.xz qemu-eaf1ffbe15fe67612c63d928415ee04eb4836dc7.zip | |
spapr: Clarify why DR connectors aren't user creatable
DR connector is a device that emulates a firmware abstraction used by PAPR
compliant guests to manage hotplug/dynamic-reconfiguration of PHBs, PCI
devices, memory, and CPUs.
It is internally created by the spapr platform and requires to be owned by
either the machine (PHBs, CPUs, memory) or by a PHB (PCI devices).
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <160250199940.765467.6896806997161856576.stgit@bahia.lan>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/ppc/spapr_drc.c')
| -rw-r--r-- | hw/ppc/spapr_drc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 697b28c343..77718cde1f 100644 --- a/hw/ppc/spapr_drc.c +++ b/hw/ppc/spapr_drc.c @@ -586,7 +586,8 @@ static void spapr_dr_connector_class_init(ObjectClass *k, void *data) dk->realize = realize; dk->unrealize = unrealize; /* - * Reason: it crashes FIXME find and document the real reason + * Reason: DR connector needs to be wired to either the machine or to a + * PHB in spapr_dr_connector_new(). */ dk->user_creatable = false; } |