diff options
| author | Thomas Huth | 2018-03-19 15:00:46 +0100 |
|---|---|---|
| committer | David Gibson | 2018-04-10 02:05:38 +0200 |
| commit | ddd835f32a18c087d3161213f47e89566ce05cc8 (patch) | |
| tree | 4d21dc9f327db3f9fc26adcf1bea67aa1eece449 /hw/ppc | |
| parent | target/ppc: Initialize lazy_tlb_flush correctly (diff) | |
| download | qemu-ddd835f32a18c087d3161213f47e89566ce05cc8.tar.gz qemu-ddd835f32a18c087d3161213f47e89566ce05cc8.tar.xz qemu-ddd835f32a18c087d3161213f47e89566ce05cc8.zip | |
hw/misc/macio: Fix crash when listing device properties of macio device
The macio-newworld device can currently be used to abort QEMU unexpectedly:
$ ppc-softmmu/qemu-system-ppc -S -M ref405ep,accel=qtest -qmp stdio
{"QMP": {"version": {"qemu": {"micro": 50, "minor": 11, "major": 2},
"package": "build-all"}, "capabilities": []}}
{ 'execute': 'qmp_capabilities' }
{"return": {}}
{ 'execute': 'device-list-properties',
'arguments': {'typename': 'macio-newworld'}}
Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222:
Device 'serial0' is in use
Aborted (core dumped)
qdev properties should be set during realize(), not during instance_init(),
so move the related code there to fix this problem.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/ppc')
0 files changed, 0 insertions, 0 deletions