diff options
| author | Daniel Henrique Barboza | 2022-03-02 06:51:39 +0100 |
|---|---|---|
| committer | Cédric Le Goater | 2022-03-02 06:51:39 +0100 |
| commit | ea8464fa27fe5acf09b90a7b9a496d3a5e0e2f21 (patch) | |
| tree | 596fa3ce0eec766d41f9098f0677188332734154 /hw/ppc | |
| parent | hw/ppc/spapr.c: fail early if no firmware found in machine_init() (diff) | |
| download | qemu-ea8464fa27fe5acf09b90a7b9a496d3a5e0e2f21.tar.gz qemu-ea8464fa27fe5acf09b90a7b9a496d3a5e0e2f21.tar.xz qemu-ea8464fa27fe5acf09b90a7b9a496d3a5e0e2f21.zip | |
hw/ppc/spapr_caps.c: use g_autofree in spapr_cap_set_string()
And get rid of the 'out' label since it's now unused.
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220228175004.8862-4-danielhb413@gmail.com>
[ clg: Fixed typo in commit log ]
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Diffstat (limited to 'hw/ppc')
| -rw-r--r-- | hw/ppc/spapr_caps.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c index 6167431271..aab313ffb1 100644 --- a/hw/ppc/spapr_caps.c +++ b/hw/ppc/spapr_caps.c @@ -120,7 +120,7 @@ static void spapr_cap_set_string(Object *obj, Visitor *v, const char *name, SpaprCapabilityInfo *cap = opaque; SpaprMachineState *spapr = SPAPR_MACHINE(obj); uint8_t i; - char *val; + g_autofree char *val = NULL; if (!visit_type_str(v, name, &val, errp)) { return; @@ -128,20 +128,18 @@ static void spapr_cap_set_string(Object *obj, Visitor *v, const char *name, if (!strcmp(val, "?")) { error_setg(errp, "%s", cap->possible->help); - goto out; + return; } for (i = 0; i < cap->possible->num; i++) { if (!strcasecmp(val, cap->possible->vals[i])) { spapr->cmd_line_caps[cap->index] = true; spapr->eff.caps[cap->index] = i; - goto out; + return; } } error_setg(errp, "Invalid capability mode \"%s\" for cap-%s", val, cap->name); -out: - g_free(val); } static void spapr_cap_get_pagesize(Object *obj, Visitor *v, const char *name, |