diff options
| author | BALATON Zoltan | 2021-01-08 23:07:38 +0100 |
|---|---|---|
| committer | David Gibson | 2021-01-19 00:20:29 +0100 |
| commit | f17969db719ef563d2f7a1b62ea5dd5087ad774a (patch) | |
| tree | 6c9a4842f40a4ea1019b00a53e33ea18fbe2f4e5 /hw/ppc | |
| parent | Revert "ppc4xx: Move common dependency on serial to common option" (diff) | |
| download | qemu-f17969db719ef563d2f7a1b62ea5dd5087ad774a.tar.gz qemu-f17969db719ef563d2f7a1b62ea5dd5087ad774a.tar.xz qemu-f17969db719ef563d2f7a1b62ea5dd5087ad774a.zip | |
sam460ex: Use type cast macro instead of simple cast
Use the PCI_BUS type cast macro to convert result of qdev_get_child_bus().
Also remove the check for NULL afterwards which should not be needed
because sysbus_create_simple() uses error_abort and we create the PCI
host object here that's expected to have a PCI bus so this shouldn't
fail. Even if it would fail that would be due to a programmer error so
an error message is not necessary.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: <a4dc55b56eed3ce899b7bf9835b980a114c52598.1610143658.git.balaton@eik.bme.hu>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/ppc')
| -rw-r--r-- | hw/ppc/sam460ex.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c index 45721ad6c7..e459b43065 100644 --- a/hw/ppc/sam460ex.c +++ b/hw/ppc/sam460ex.c @@ -419,11 +419,8 @@ static void sam460ex_init(MachineState *machine) /* All PCI irqs are connected to the same UIC pin (cf. UBoot source) */ dev = sysbus_create_simple("ppc440-pcix-host", 0xc0ec00000, qdev_get_gpio_in(uic[1], 0)); - pci_bus = (PCIBus *)qdev_get_child_bus(dev, "pci.0"); - if (!pci_bus) { - error_report("couldn't create PCI controller!"); - exit(1); - } + pci_bus = PCI_BUS(qdev_get_child_bus(dev, "pci.0")); + memory_region_init_alias(isa, NULL, "isa_mmio", get_system_io(), 0, 0x10000); memory_region_add_subregion(get_system_memory(), 0xc08000000, isa); |