diff options
| author | BALATON Zoltan | 2020-07-05 19:22:11 +0200 |
|---|---|---|
| committer | Alistair Francis | 2020-09-26 01:52:08 +0200 |
| commit | 617160c9e1f8022563c33aa7fd204535d4d49f8c (patch) | |
| tree | 9bdc09357ec3690c71f21058d88bada7b977bb33 /hw/riscv | |
| parent | Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20200925a'... (diff) | |
| download | qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.tar.gz qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.tar.xz qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.zip | |
load_elf: Remove unused address variables from callers
Several callers of load_elf() pass pointers for lowaddr and highaddr
parameters which are then not used for anything. This may stem from a
misunderstanding that load_elf need a value here but in fact it can
take NULL to ignore these values. Remove such unused variables and
pass NULL instead from callers that don't need these.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
Message-Id: <20200705174020.BDD0174633F@zero.eik.bme.hu>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Diffstat (limited to 'hw/riscv')
| -rw-r--r-- | hw/riscv/boot.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c index 4c6c101ff1..21adaae56e 100644 --- a/hw/riscv/boot.c +++ b/hw/riscv/boot.c @@ -91,10 +91,10 @@ target_ulong riscv_load_firmware(const char *firmware_filename, hwaddr firmware_load_addr, symbol_fn_t sym_cb) { - uint64_t firmware_entry, firmware_start, firmware_end; + uint64_t firmware_entry; if (load_elf_ram_sym(firmware_filename, NULL, NULL, NULL, - &firmware_entry, &firmware_start, &firmware_end, NULL, + &firmware_entry, NULL, NULL, NULL, 0, EM_RISCV, 1, 0, NULL, true, sym_cb) > 0) { return firmware_entry; } @@ -110,10 +110,10 @@ target_ulong riscv_load_firmware(const char *firmware_filename, target_ulong riscv_load_kernel(const char *kernel_filename, symbol_fn_t sym_cb) { - uint64_t kernel_entry, kernel_high; + uint64_t kernel_entry; if (load_elf_ram_sym(kernel_filename, NULL, NULL, NULL, - &kernel_entry, NULL, &kernel_high, NULL, 0, + &kernel_entry, NULL, NULL, NULL, 0, EM_RISCV, 1, 0, NULL, true, sym_cb) > 0) { return kernel_entry; } |