summaryrefslogtreecommitdiffstats
path: root/hw/rtc
diff options
context:
space:
mode:
authorGerd Hoffmann2020-05-15 17:04:08 +0200
committerMichael S. Tsirkin2020-06-09 18:46:45 +0200
commitf592b94f3cbd5325bcf5142509b60cb6ab252770 (patch)
treeb0b0700eece6a5b1afb66ab455fcebc53e33ebfc /hw/rtc
parentacpi: move aml builder code for rtc device (diff)
downloadqemu-f592b94f3cbd5325bcf5142509b60cb6ab252770.tar.gz
qemu-f592b94f3cbd5325bcf5142509b60cb6ab252770.tar.xz
qemu-f592b94f3cbd5325bcf5142509b60cb6ab252770.zip
acpi: rtc: use a single crs range
Use a single io range for _CRS instead of two, following what real hardware does. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> Message-Id: <20200515150421.25479-4-kraxel@redhat.com>
Diffstat (limited to 'hw/rtc')
-rw-r--r--hw/rtc/mc146818rtc.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c
index fe05a4488e..1e9fa0f33f 100644
--- a/hw/rtc/mc146818rtc.c
+++ b/hw/rtc/mc146818rtc.c
@@ -1013,12 +1013,14 @@ static void rtc_build_aml(ISADevice *isadev, Aml *scope)
Aml *dev;
Aml *crs;
+ /*
+ * Reserving 8 io ports here, following what physical hardware
+ * does, even though qemu only responds to the first two ports.
+ */
crs = aml_resource_template();
aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE,
- 0x10, 0x02));
+ 0x01, 0x08));
aml_append(crs, aml_irq_no_flags(RTC_ISA_IRQ));
- aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE + 2, RTC_ISA_BASE + 2,
- 0x02, 0x06));
dev = aml_device("RTC");
aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00")));