diff options
| author | Janosch Frank | 2020-10-22 12:31:34 +0200 |
|---|---|---|
| committer | Cornelia Huck | 2020-10-22 15:47:27 +0200 |
| commit | 3df4843d0e612a3c838e8d94c3e9c24520f2e680 (patch) | |
| tree | 65acbcce796c20304e0a6705a40aabe5bac16609 /hw/s390x | |
| parent | s390x/s390-virtio-ccw: Reset PCI devices during subsystem reset (diff) | |
| download | qemu-3df4843d0e612a3c838e8d94c3e9c24520f2e680.tar.gz qemu-3df4843d0e612a3c838e8d94c3e9c24520f2e680.tar.xz qemu-3df4843d0e612a3c838e8d94c3e9c24520f2e680.zip | |
s390x: pv: Remove sclp boundary checks
The SCLP boundary cross check is done by the Ultravisor for a
protected guest, hence we don't need to do it. As QEMU doesn't get a
valid SCCB address in protected mode this is even problematic and can
lead to QEMU reporting a false boundary cross error.
Fixes: db13387ca0 ("s390/sclp: rework sclp boundary checks")
Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Tested-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Acked-by: Halil Pasic <pasic@linux.ibm.com>
Acked-by: David Hildenbrand <david@redhat.com>
Message-Id: <20201022103135.126033-2-frankja@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Diffstat (limited to 'hw/s390x')
| -rw-r--r-- | hw/s390x/sclp.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c index 00f1e4648d..0cf2290826 100644 --- a/hw/s390x/sclp.c +++ b/hw/s390x/sclp.c @@ -285,11 +285,6 @@ int sclp_service_call_protected(CPUS390XState *env, uint64_t sccb, goto out_write; } - if (!sccb_verify_boundary(sccb, be16_to_cpu(work_sccb->h.length), code)) { - work_sccb->h.response_code = cpu_to_be16(SCLP_RC_SCCB_BOUNDARY_VIOLATION); - goto out_write; - } - sclp_c->execute(sclp, work_sccb, code); out_write: s390_cpu_pv_mem_write(env_archcpu(env), 0, work_sccb, |