diff options
| author | Rony Weng | 2016-08-29 09:52:18 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2016-09-13 19:08:45 +0200 |
| commit | 48b6206305b8d56524ac2ee347b68e6e0a528559 (patch) | |
| tree | 4d92ed573c18c4df74824ecdde8796c059cdf5ef /hw/scsi | |
| parent | MAINTAINERS: add myself as stubs maintainers (diff) | |
| download | qemu-48b6206305b8d56524ac2ee347b68e6e0a528559.tar.gz qemu-48b6206305b8d56524ac2ee347b68e6e0a528559.tar.xz qemu-48b6206305b8d56524ac2ee347b68e6e0a528559.zip | |
scsi-disk: change disk serial length from 20 to 36
Openstack Cinder assigns volume a 36 characters uuid as serial.
QEMU will shrinks the uuid to 20 characters, which does not match
the original uuid.
Note that there is no limit to the length of the serial number in
the SCSI spec. 20 was copy-pasted from virtio-blk which in turn was
copy-pasted from ATA; 36 is even more arbitrary. However, bumping it
up too much might cause issues (e.g. 252 seems to make sense because
then the maximum amount of returned data is 256; but who knows there's
no off-by-one somewhere for such a nicely rounded number).
Signed-off-by: Rony Weng <ronyweng@synology.com>
Message-Id: <1472457138-23386-1-git-send-email-ronyweng@synology.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/scsi')
| -rw-r--r-- | hw/scsi/scsi-disk.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 99c9d618da..77cba31e30 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -599,8 +599,8 @@ static int scsi_disk_emulate_inquiry(SCSIRequest *req, uint8_t *outbuf) } l = strlen(s->serial); - if (l > 20) { - l = 20; + if (l > 36) { + l = 36; } DPRINTF("Inquiry EVPD[Serial number] " |