diff options
| author | Stefan Hajnoczi | 2015-07-30 15:16:12 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2015-07-30 15:44:04 +0200 |
| commit | c85a7a0057ca454607a40cde991d495e0deec34d (patch) | |
| tree | 5db3f00072feaf3f0807e1ab2827cf9f5cfc64af /hw/scsi | |
| parent | virtio-scsi: use virtqueue_map_sg() when loading requests (diff) | |
| download | qemu-c85a7a0057ca454607a40cde991d495e0deec34d.tar.gz qemu-c85a7a0057ca454607a40cde991d495e0deec34d.tar.xz qemu-c85a7a0057ca454607a40cde991d495e0deec34d.zip | |
scsi-disk: fix cmd.mode field typo
The cmd.xfer field is the data length. The cmd.mode field is the data
transfer direction.
scsi_handle_rw_error() was using the wrong error policy for read
requests.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <1438262173-11546-3-git-send-email-stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/scsi')
| -rw-r--r-- | hw/scsi/scsi-disk.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 64f0694734..73fed3f233 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -399,7 +399,7 @@ static void scsi_read_data(SCSIRequest *req) */ static int scsi_handle_rw_error(SCSIDiskReq *r, int error) { - bool is_read = (r->req.cmd.xfer == SCSI_XFER_FROM_DEV); + bool is_read = (r->req.cmd.mode == SCSI_XFER_FROM_DEV); SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev, r->req.dev); BlockErrorAction action = blk_get_error_action(s->qdev.conf.blk, is_read, error); |