diff options
| author | Peter Maydell | 2016-08-05 12:03:59 +0200 |
|---|---|---|
| committer | Peter Maydell | 2016-08-08 14:58:42 +0200 |
| commit | 47dc0ec576c3d8748985e34d273c8dc0465c5ddb (patch) | |
| tree | 8f5d995ce46474c67d5626c2810959fa04705fa5 /hw/sparc | |
| parent | Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2016-08-08' into... (diff) | |
| download | qemu-47dc0ec576c3d8748985e34d273c8dc0465c5ddb.tar.gz qemu-47dc0ec576c3d8748985e34d273c8dc0465c5ddb.tar.xz qemu-47dc0ec576c3d8748985e34d273c8dc0465c5ddb.zip | |
hw/sparc/leon3: Don't call get_image_size() on a NULL pointer
get_image_size() doesn't handle being passed a NULL pointer, so
avoid doing that. Spotted by the clang ub sanitizer (which notices
the attempt to pass NULL to open()).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 1470391439-28427-1-git-send-email-peter.maydell@linaro.org
Diffstat (limited to 'hw/sparc')
| -rw-r--r-- | hw/sparc/leon3.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index dbae41f3a4..6e16478413 100644 --- a/hw/sparc/leon3.c +++ b/hw/sparc/leon3.c @@ -171,7 +171,11 @@ static void leon3_generic_hw_init(MachineState *machine) } filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name); - bios_size = get_image_size(filename); + if (filename) { + bios_size = get_image_size(filename); + } else { + bios_size = -1; + } if (bios_size > prom_size) { fprintf(stderr, "qemu: could not load prom '%s': file too big\n", |