summaryrefslogtreecommitdiffstats
path: root/hw/sparc
diff options
context:
space:
mode:
authorDavid Gibson2016-08-08 02:06:25 +0200
committerDavid Gibson2016-08-08 02:06:25 +0200
commit57c0eb1e0d6d8f01550d10cf08747f25cd537777 (patch)
treedca68aefc864954a3429af532d126d9d8430a9f2 /hw/sparc
parentmacio: set res_count value to 0 after non-block ATAPI DMA transfers (diff)
downloadqemu-57c0eb1e0d6d8f01550d10cf08747f25cd537777.tar.gz
qemu-57c0eb1e0d6d8f01550d10cf08747f25cd537777.tar.xz
qemu-57c0eb1e0d6d8f01550d10cf08747f25cd537777.zip
spapr: Fix undefined behaviour in spapr_tce_reset()
When a TCE table (sPAPR IOMMU context) is in disabled state (which is true by default for the 64-bit window), it has tcet->nb_table == 0 and tcet->table == NULL. However, on system reset, spapr_tce_reset() executes, which unconditionally calls memset(tcet->table, 0, table_size); We get away with this in practice, because it's a zero length memset(), but memset() on a NULL pointer is undefined behaviour, so we should not call it in this case. Reported-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/sparc')
0 files changed, 0 insertions, 0 deletions