diff options
| author | Peter Maydell | 2018-09-25 15:02:32 +0200 |
|---|---|---|
| committer | Peter Maydell | 2018-09-25 16:13:24 +0200 |
| commit | 3e1dd459cbd95c66753f7c9368e680dde2ba60e2 (patch) | |
| tree | 4ce008a68e85a76c331f5789c1b1b0254d8feac2 /hw/timer/cmsdk-apb-dualtimer.c | |
| parent | hw/net/pcnet-pci: Unify pcnet_ioport_read/write and pcnet_mmio_read/write (diff) | |
| download | qemu-3e1dd459cbd95c66753f7c9368e680dde2ba60e2.tar.gz qemu-3e1dd459cbd95c66753f7c9368e680dde2ba60e2.tar.xz qemu-3e1dd459cbd95c66753f7c9368e680dde2ba60e2.zip | |
hw/timer/cmsdk-apb-dualtimer: Add missing 'break' statements
Add 'break' statements missing from a switch in the APB dual-timer
write function. Spotted by Coverity as CID 1395626 and 1395633.
Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180924123122.14549-1-peter.maydell@linaro.org
Diffstat (limited to 'hw/timer/cmsdk-apb-dualtimer.c')
| -rw-r--r-- | hw/timer/cmsdk-apb-dualtimer.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/hw/timer/cmsdk-apb-dualtimer.c b/hw/timer/cmsdk-apb-dualtimer.c index ccd49753b7..30245990f3 100644 --- a/hw/timer/cmsdk-apb-dualtimer.c +++ b/hw/timer/cmsdk-apb-dualtimer.c @@ -296,9 +296,11 @@ static void cmsdk_apb_dualtimer_write(void *opaque, hwaddr offset, case A_TIMERITCR: s->timeritcr = value & R_TIMERITCR_VALID_MASK; cmsdk_apb_dualtimer_update(s); + break; case A_TIMERITOP: s->timeritop = value & R_TIMERITOP_VALID_MASK; cmsdk_apb_dualtimer_update(s); + break; default: bad_offset: qemu_log_mask(LOG_GUEST_ERROR, |