diff options
| author | Philippe Mathieu-Daudé | 2019-07-15 15:17:03 +0200 |
|---|---|---|
| committer | Peter Maydell | 2019-07-15 15:17:03 +0200 |
| commit | 936a236c4e4b1068ade99220260cd04f68eb0212 (patch) | |
| tree | c18d2e5e53e3de4ad62b3fd12748dee982d5f7f3 /hw/timer/digic-timer.c | |
| parent | hw/ssi/xilinx_spips: Convert lqspi_read() to read_with_attrs (diff) | |
| download | qemu-936a236c4e4b1068ade99220260cd04f68eb0212.tar.gz qemu-936a236c4e4b1068ade99220260cd04f68eb0212.tar.xz qemu-936a236c4e4b1068ade99220260cd04f68eb0212.zip | |
hw/ssi/xilinx_spips: Avoid AXI writes to the LQSPI linear memory
Lei Sun found while auditing the code that a CPU write would
trigger a NULL pointer dereference.
>From UG1085 datasheet [*] AXI writes in this region are ignored
and generates an AXI Slave Error (SLVERR).
Fix by implementing the write_with_attrs() handler.
Return MEMTX_ERROR when the region is accessed (this error maps
to an AXI slave error).
[*] https://www.xilinx.com/support/documentation/user_guides/ug1085-zynq-ultrascale-trm.pdf
Reported-by: Lei Sun <slei.casper@gmail.com>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Tested-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'hw/timer/digic-timer.c')
0 files changed, 0 insertions, 0 deletions