diff options
| author | Markus Armbruster | 2020-07-07 18:05:43 +0200 |
|---|---|---|
| committer | Markus Armbruster | 2020-07-10 15:18:08 +0200 |
| commit | 3882578bb559e5caf9b79cabcb88b69270af68c0 (patch) | |
| tree | ebaa5b42c644169e569811ddc9da705bebdc9d33 /hw/usb/dev-storage.c | |
| parent | qemu-option: Use returned bool to check for failure (diff) | |
| download | qemu-3882578bb559e5caf9b79cabcb88b69270af68c0.tar.gz qemu-3882578bb559e5caf9b79cabcb88b69270af68c0.tar.xz qemu-3882578bb559e5caf9b79cabcb88b69270af68c0.zip | |
block: Avoid error accumulation in bdrv_img_create()
When creating an image fails because the format doesn't support option
"backing_file" or "backing_fmt", bdrv_img_create() first has
qemu_opt_set() put a generic error into @local_err, then puts the real
error into @errp with error_setg(), and then propagates the former to
the latter, which throws away the generic error. A bit complicated,
but works.
Now that qemu_opt_set() returns a useful value, we can simply ignore
the generic error instead.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-16-armbru@redhat.com>
Diffstat (limited to 'hw/usb/dev-storage.c')
0 files changed, 0 insertions, 0 deletions