diff options
| author | Philippe Mathieu-Daudé | 2022-08-19 17:39:29 +0200 |
|---|---|---|
| committer | Peter Maydell | 2022-09-22 17:38:28 +0200 |
| commit | 29d81e429d16fe8f0f1cd99e63507ca53ca1945c (patch) | |
| tree | dee1c34a75e25b3a06b525b1f5f0d9aae9804c72 /hw/usb | |
| parent | hw/i386/multiboot: Avoid dynamic stack allocation (diff) | |
| download | qemu-29d81e429d16fe8f0f1cd99e63507ca53ca1945c.tar.gz qemu-29d81e429d16fe8f0f1cd99e63507ca53ca1945c.tar.xz qemu-29d81e429d16fe8f0f1cd99e63507ca53ca1945c.zip | |
hw/usb/hcd-ohci: Use definition to avoid dynamic stack allocation
The compiler isn't clever enough to figure 'width' is a constant,
so help it by using a definitions instead.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-10-peter.maydell@linaro.org
Diffstat (limited to 'hw/usb')
| -rw-r--r-- | hw/usb/hcd-ohci.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index 895b29fb86..5585fd32cc 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -805,13 +805,14 @@ static int ohci_service_iso_td(OHCIState *ohci, struct ohci_ed *ed) return 1; } +#define HEX_CHAR_PER_LINE 16 + static void ohci_td_pkt(const char *msg, const uint8_t *buf, size_t len) { bool print16; bool printall; - const int width = 16; int i; - char tmp[3 * width + 1]; + char tmp[3 * HEX_CHAR_PER_LINE + 1]; char *p = tmp; print16 = !!trace_event_get_state_backends(TRACE_USB_OHCI_TD_PKT_SHORT); @@ -822,7 +823,7 @@ static void ohci_td_pkt(const char *msg, const uint8_t *buf, size_t len) } for (i = 0; ; i++) { - if (i && (!(i % width) || (i == len))) { + if (i && (!(i % HEX_CHAR_PER_LINE) || (i == len))) { if (!printall) { trace_usb_ohci_td_pkt_short(msg, tmp); break; |