summaryrefslogtreecommitdiffstats
path: root/hw/usb
diff options
context:
space:
mode:
authorPeter Xu2016-03-09 07:07:20 +0100
committerGerd Hoffmann2016-03-18 13:56:24 +0100
commitf34d57d359bb539c482a69f2732bf05787127ed4 (patch)
treee47b3b0826e1ab7baa4b0c76adb45263fb164bbf /hw/usb
parentusb: fix unbound stack usage for usb_mtp_add_str (diff)
downloadqemu-f34d57d359bb539c482a69f2732bf05787127ed4.tar.gz
qemu-f34d57d359bb539c482a69f2732bf05787127ed4.tar.xz
qemu-f34d57d359bb539c482a69f2732bf05787127ed4.zip
usb: fix unbound stack warning for inotify_watchfn
Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Message-id: 1457503640-31473-1-git-send-email-peterx@redhat.com Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'hw/usb')
-rw-r--r--hw/usb/dev-mtp.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 62fb7cd518..01c5e519ac 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -433,12 +433,11 @@ static void inotify_watchfn(void *arg)
MTPState *s = arg;
ssize_t bytes;
/* From the man page: atleast one event can be read */
- int len = sizeof(struct inotify_event) + NAME_MAX + 1;
int pos;
- char buf[len];
+ char buf[sizeof(struct inotify_event) + NAME_MAX + 1];
for (;;) {
- bytes = read(s->inotifyfd, buf, len);
+ bytes = read(s->inotifyfd, buf, sizeof(buf));
pos = 0;
if (bytes <= 0) {