diff options
| author | Markus Armbruster | 2020-07-21 14:11:53 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin | 2020-07-22 13:57:07 +0200 |
| commit | cf4e3d000e438d04077a56c401b41f3336a2a09d (patch) | |
| tree | d32172230f69c1c30fa8749c6ca775762cd83d4d /hw/virtio/virtio-rng-pci.c | |
| parent | acpi: accept byte and word access to core ACPI registers (diff) | |
| download | qemu-cf4e3d000e438d04077a56c401b41f3336a2a09d.tar.gz qemu-cf4e3d000e438d04077a56c401b41f3336a2a09d.tar.xz qemu-cf4e3d000e438d04077a56c401b41f3336a2a09d.zip | |
virtio: Drop broken and superfluous object_property_set_link()
virtio_crypto_pci_realize() and copies the value of vcrypto->vdev's
property "cryptodev" to vcrypto's property:
object_property_set_link(OBJECT(vrng), "rng", OBJECT(vrng->vdev.conf.rng),
NULL);
Since it does so only after realize, this always fails, but the error
is ignored.
It's actually superfluous: vcrypto's property is an alias of
vcrypto->vdev's property, created by virtio_instance_init_common().
Drop the call.
Same for virtio_ccw_crypto_realize(), virtio_rng_pci_realize(),
virtio_ccw_rng_realize().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200721121153.1128844-1-armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/virtio/virtio-rng-pci.c')
| -rw-r--r-- | hw/virtio/virtio-rng-pci.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/hw/virtio/virtio-rng-pci.c b/hw/virtio/virtio-rng-pci.c index 2f0b529b62..8afbb4c209 100644 --- a/hw/virtio/virtio-rng-pci.c +++ b/hw/virtio/virtio-rng-pci.c @@ -38,9 +38,6 @@ static void virtio_rng_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp) if (!qdev_realize(vdev, BUS(&vpci_dev->bus), errp)) { return; } - - object_property_set_link(OBJECT(vrng), "rng", OBJECT(vrng->vdev.conf.rng), - NULL); } static void virtio_rng_pci_class_init(ObjectClass *klass, void *data) |