summaryrefslogtreecommitdiffstats
path: root/hw/virtio
diff options
context:
space:
mode:
authorAlex Bennée2022-08-02 11:49:49 +0200
committerMichael S. Tsirkin2022-10-07 15:41:51 +0200
commit02b61f38d3574900fb4cc4c450b17c75956a6a04 (patch)
treeb49d71c03a39d9db0280babb066a0f2f02a3ebf9 /hw/virtio
parentMerge tag 'pull-testing-gdbstub-plugins-gitdm-061022-3' of https://github.com... (diff)
downloadqemu-02b61f38d3574900fb4cc4c450b17c75956a6a04.tar.gz
qemu-02b61f38d3574900fb4cc4c450b17c75956a6a04.tar.xz
qemu-02b61f38d3574900fb4cc4c450b17c75956a6a04.zip
hw/virtio: incorporate backend features in features
There are some extra bits used over a vhost-user connection which are hidden from the device itself. We need to set them here to ensure we enable things like the protocol extensions. Currently net/vhost-user.c has it's own inscrutable way of persisting this data but it really should live in the core vhost_user code. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Message-Id: <20220726192150.2435175-7-alex.bennee@linaro.org> Message-Id: <20220802095010.3330793-2-alex.bennee@linaro.org> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Diffstat (limited to 'hw/virtio')
-rw-r--r--hw/virtio/vhost-user.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 70748e61e0..0b7e41ffe8 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -1460,7 +1460,14 @@ static int vhost_user_set_features(struct vhost_dev *dev,
*/
bool log_enabled = features & (0x1ULL << VHOST_F_LOG_ALL);
- return vhost_user_set_u64(dev, VHOST_USER_SET_FEATURES, features,
+ /*
+ * We need to include any extra backend only feature bits that
+ * might be needed by our device. Currently this includes the
+ * VHOST_USER_F_PROTOCOL_FEATURES bit for enabling protocol
+ * features.
+ */
+ return vhost_user_set_u64(dev, VHOST_USER_SET_FEATURES,
+ features | dev->backend_features,
log_enabled);
}