diff options
| author | Igor Druzhinin | 2018-04-17 16:54:15 +0200 |
|---|---|---|
| committer | Stefano Stabellini | 2018-05-18 20:01:52 +0200 |
| commit | 84201604c77808d6b2fa5139ded83d1e739a3f8c (patch) | |
| tree | 7a423a099af084c3bf81ea9c3ffe13ea22e18821 /hw/xen/xen_pt.c | |
| parent | xen-pvdevice: Introduce a simplistic xen-pvdevice save state (diff) | |
| download | qemu-84201604c77808d6b2fa5139ded83d1e739a3f8c.tar.gz qemu-84201604c77808d6b2fa5139ded83d1e739a3f8c.tar.xz qemu-84201604c77808d6b2fa5139ded83d1e739a3f8c.zip | |
xen/pt: use address_space_memory object for memory region hooks
Commit 99605175c (xen-pt: Fix PCI devices re-attach failed) introduced
a subtle bug. As soon as the guest switches off Bus Mastering on the
device it immediately causes all the BARs be unmapped due to the DMA
address space of the device being changed. This is undesired behavior
because the guest may try to communicate with the device after that
which triggers the following errors in the logs:
[00:05.0] xen_pt_bar_read: Error: Should not read BAR through QEMU. @0x0000000000000200
[00:05.0] xen_pt_bar_write: Error: Should not write BAR through QEMU. @0x0000000000000200
The issue that the original patch tried to workaround (uneven number of
region_add/del calls on device attach/detach) was fixed in d25836cafd
(memory: do explicit cleanup when remove listeners).
Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
Reported-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Diffstat (limited to 'hw/xen/xen_pt.c')
| -rw-r--r-- | hw/xen/xen_pt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 9b7a960de1..e5a6eff44f 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -907,7 +907,7 @@ out: } } - memory_listener_register(&s->memory_listener, &s->dev.bus_master_as); + memory_listener_register(&s->memory_listener, &address_space_memory); memory_listener_register(&s->io_listener, &address_space_io); s->listener_set = true; XEN_PT_LOG(d, |