diff options
author | liujunjie | 2018-09-17 15:48:45 +0200 |
---|---|---|
committer | Jason Wang | 2018-10-19 05:15:03 +0200 |
commit | 7da2d99fb9fbf30104125c061caaff330e362d74 (patch) | |
tree | 24c18d01765f6539a8a68105a5245cb4b2a2a02f /hw/xen/xen_pt_graphics.c | |
parent | docs: Add COLO status diagram to COLO-FT.txt (diff) | |
download | qemu-7da2d99fb9fbf30104125c061caaff330e362d74.tar.gz qemu-7da2d99fb9fbf30104125c061caaff330e362d74.tar.xz qemu-7da2d99fb9fbf30104125c061caaff330e362d74.zip |
clean up callback when del virtqueue
Before, we did not clear callback like handle_output when delete
the virtqueue which may result be segmentfault.
The scene is as follows:
1. Start a vm with multiqueue vhost-net,
2. then we write VIRTIO_PCI_GUEST_FEATURES in PCI configuration to
triger multiqueue disable in this vm which will delete the virtqueue.
In this step, the tx_bh is deleted but the callback virtio_net_handle_tx_bh
still exist.
3. Finally, we write VIRTIO_PCI_QUEUE_NOTIFY in PCI configuration to
notify the deleted virtqueue. In this way, virtio_net_handle_tx_bh
will be called and qemu will be crashed.
Although the way described above is uncommon, we had better reinforce it.
CC: qemu-stable@nongnu.org
Signed-off-by: liujunjie <liujunjie23@huawei.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'hw/xen/xen_pt_graphics.c')
0 files changed, 0 insertions, 0 deletions