diff options
| author | BALATON Zoltan | 2020-07-05 19:22:11 +0200 |
|---|---|---|
| committer | Alistair Francis | 2020-09-26 01:52:08 +0200 |
| commit | 617160c9e1f8022563c33aa7fd204535d4d49f8c (patch) | |
| tree | 9bdc09357ec3690c71f21058d88bada7b977bb33 /hw/xtensa | |
| parent | Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20200925a'... (diff) | |
| download | qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.tar.gz qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.tar.xz qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.zip | |
load_elf: Remove unused address variables from callers
Several callers of load_elf() pass pointers for lowaddr and highaddr
parameters which are then not used for anything. This may stem from a
misunderstanding that load_elf need a value here but in fact it can
take NULL to ignore these values. Remove such unused variables and
pass NULL instead from callers that don't need these.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
Message-Id: <20200705174020.BDD0174633F@zero.eik.bme.hu>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Diffstat (limited to 'hw/xtensa')
| -rw-r--r-- | hw/xtensa/sim.c | 3 | ||||
| -rw-r--r-- | hw/xtensa/xtfpga.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/hw/xtensa/sim.c b/hw/xtensa/sim.c index aeb46d86f5..cbac50db2d 100644 --- a/hw/xtensa/sim.c +++ b/hw/xtensa/sim.c @@ -106,9 +106,8 @@ void xtensa_sim_load_kernel(XtensaCPU *cpu, MachineState *machine) if (kernel_filename) { uint64_t elf_entry; - uint64_t elf_lowaddr; int success = load_elf(kernel_filename, NULL, translate_phys_addr, cpu, - &elf_entry, &elf_lowaddr, NULL, NULL, big_endian, + &elf_entry, NULL, NULL, NULL, big_endian, EM_XTENSA, 0, 0); if (success > 0) { diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c index 10de15855a..b1470b88e6 100644 --- a/hw/xtensa/xtfpga.c +++ b/hw/xtensa/xtfpga.c @@ -413,9 +413,8 @@ static void xtfpga_init(const XtfpgaBoardDesc *board, MachineState *machine) env->regs[2] = tagptr; uint64_t elf_entry; - uint64_t elf_lowaddr; int success = load_elf(kernel_filename, NULL, translate_phys_addr, cpu, - &elf_entry, &elf_lowaddr, NULL, NULL, be, EM_XTENSA, 0, 0); + &elf_entry, NULL, NULL, NULL, be, EM_XTENSA, 0, 0); if (success > 0) { entry_point = elf_entry; } else { |