diff options
| author | Paolo Bonzini | 2020-10-27 09:44:18 +0100 |
|---|---|---|
| committer | Paolo Bonzini | 2020-12-15 18:51:48 +0100 |
| commit | 164dafd1744c69d268b89015977e19d8a9617fdf (patch) | |
| tree | 7c3f6a9c5dfb766bdd25cfa87f37201095cd674f /hw | |
| parent | Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request... (diff) | |
| download | qemu-164dafd1744c69d268b89015977e19d8a9617fdf.tar.gz qemu-164dafd1744c69d268b89015977e19d8a9617fdf.tar.xz qemu-164dafd1744c69d268b89015977e19d8a9617fdf.zip | |
remove preconfig state
The preconfig state is only used if -incoming is not specified, which
makes the RunState state machine more tricky than it need be. However
there is already an equivalent condition which works even with -incoming,
namely qdev_hotplug. Use it instead of a separate runstate.
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/core/machine-qmp-cmds.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c index 5362c80a18..cb9387c5f5 100644 --- a/hw/core/machine-qmp-cmds.c +++ b/hw/core/machine-qmp-cmds.c @@ -286,9 +286,8 @@ HotpluggableCPUList *qmp_query_hotpluggable_cpus(Error **errp) void qmp_set_numa_node(NumaOptions *cmd, Error **errp) { - if (!runstate_check(RUN_STATE_PRECONFIG)) { - error_setg(errp, "The command is permitted only in '%s' state", - RunState_str(RUN_STATE_PRECONFIG)); + if (qdev_hotplug) { + error_setg(errp, "The command is permitted only before the machine has been created"); return; } |