diff options
| author | Markus Armbruster | 2013-06-07 15:00:35 +0200 |
|---|---|---|
| committer | Anthony Liguori | 2013-06-14 15:58:58 +0200 |
| commit | 527cd96f15348f4454d5bb71f69aaeb95461c90e (patch) | |
| tree | e24149197179e4be201ebb3fbcb115ecc80c004d /hw | |
| parent | smbios: Clean up smbios_add_field() parameters (diff) | |
| download | qemu-527cd96f15348f4454d5bb71f69aaeb95461c90e.tar.gz qemu-527cd96f15348f4454d5bb71f69aaeb95461c90e.tar.xz qemu-527cd96f15348f4454d5bb71f69aaeb95461c90e.zip | |
smbios: Fix -smbios type=0, release=... for big endian hosts
Classic endianness bug due to careless dirty coding: assuming reading
a byte from an int variable gets the least significant byte.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Laszlo "ever the optimist" Ersek <lersek@redhat.com>
Message-id: 1370610036-10577-6-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/i386/smbios.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index 322f0a0d66..6431dd4d84 100644 --- a/hw/i386/smbios.c +++ b/hw/i386/smbios.c @@ -127,6 +127,7 @@ void smbios_add_field(int type, int offset, const void *data, size_t len) static void smbios_build_type_0_fields(const char *t) { char buf[1024]; + unsigned char major, minor; if (get_param_value(buf, sizeof(buf), "vendor", t)) smbios_add_field(0, offsetof(struct smbios_type_0, vendor_str), @@ -139,8 +140,7 @@ static void smbios_build_type_0_fields(const char *t) bios_release_date_str), buf, strlen(buf) + 1); if (get_param_value(buf, sizeof(buf), "release", t)) { - int major, minor; - sscanf(buf, "%d.%d", &major, &minor); + sscanf(buf, "%hhu.%hhu", &major, &minor); smbios_add_field(0, offsetof(struct smbios_type_0, system_bios_major_release), &major, 1); |