diff options
| author | Anthony Liguori | 2013-04-05 15:46:00 +0200 |
|---|---|---|
| committer | Anthony Liguori | 2013-04-05 19:53:33 +0200 |
| commit | 893986fe94eb229f2317f50fac0e35e068eb66ba (patch) | |
| tree | 2fb99f66ab6e99e632980a96cdfee3e9d21d0067 /hw | |
| parent | qemu-char: eliminate busy waiting on can_read returning zero (diff) | |
| download | qemu-893986fe94eb229f2317f50fac0e35e068eb66ba.tar.gz qemu-893986fe94eb229f2317f50fac0e35e068eb66ba.tar.xz qemu-893986fe94eb229f2317f50fac0e35e068eb66ba.zip | |
main-loop: drop the BQL if the I/O appears to be spinning
The char-flow refactoring introduced a busy-wait that depended on
an action from the VCPU thread. However, the VCPU thread could
never take that action because the busy-wait starved the VCPU thread
of the BQL because it never dropped the mutex while running select.
Paolo doesn't want to drop this optimization for fear that we will
stop detecting these busy waits. I'm afraid to keep this optimization
even with the busy-wait fixed because I think a similar problem can
occur just with heavy I/O thread load manifesting itself as VCPU pauses.
As a compromise, introduce an artificial timeout after a thousand
iterations but print a rate limited warning when this happens. This
let's us still detect when this condition occurs without it being
a fatal error.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Message-id: 1365169560-11012-1-git-send-email-aliguori@us.ibm.com
Diffstat (limited to 'hw')
0 files changed, 0 insertions, 0 deletions