diff options
| author | Peter Xu | 2017-05-19 05:19:41 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin | 2017-05-25 20:25:27 +0200 |
| commit | ad523590f62cf5d44e97388de370d27b95b25aff (patch) | |
| tree | ed655b12b21d9c9b5507fed8ed3be9ca17ea54da /hw | |
| parent | memory: tune last param of iommu_ops.translate() (diff) | |
| download | qemu-ad523590f62cf5d44e97388de370d27b95b25aff.tar.gz qemu-ad523590f62cf5d44e97388de370d27b95b25aff.tar.xz qemu-ad523590f62cf5d44e97388de370d27b95b25aff.zip | |
memory: remove the last param in memory_region_iommu_replay()
We were always passing in that one as "false" to assume that's an read
operation, and we also assume that IOMMU translation would always have
that read permission. A better permission would be IOMMU_NONE since the
replay is after all not a real read operation, but just a page table
rebuilding process.
CC: David Gibson <david@gibson.dropbear.id.au>
CC: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/vfio/common.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/vfio/common.c b/hw/vfio/common.c index a8f12eeb35..b9abe77f5a 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -502,7 +502,7 @@ static void vfio_listener_region_add(MemoryListener *listener, QLIST_INSERT_HEAD(&container->giommu_list, giommu, giommu_next); memory_region_register_iommu_notifier(giommu->iommu, &giommu->n); - memory_region_iommu_replay(giommu->iommu, &giommu->n, false); + memory_region_iommu_replay(giommu->iommu, &giommu->n); return; } |