diff options
| author | Prasad J Pandit | 2016-05-25 14:25:10 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2016-05-29 09:11:11 +0200 |
| commit | b60bdd1f1ee1616b7a9aeeffb4088e1ce2710fb2 (patch) | |
| tree | 0e470ca2c4bfa4d518b7a9249a5406feb4a665e9 /hw | |
| parent | scsi: megasas: initialise local configuration data buffer (diff) | |
| download | qemu-b60bdd1f1ee1616b7a9aeeffb4088e1ce2710fb2.tar.gz qemu-b60bdd1f1ee1616b7a9aeeffb4088e1ce2710fb2.tar.xz qemu-b60bdd1f1ee1616b7a9aeeffb4088e1ce2710fb2.zip | |
scsi: megasas: check 'read_queue_head' index value
While doing MegaRAID SAS controller command frame lookup, routine
'megasas_lookup_frame' uses 'read_queue_head' value as an index
into 'frames[MEGASAS_MAX_FRAMES=2048]' array. Limit its value
within array bounds to avoid any OOB access.
Reported-by: Li Qiang <liqiang6-s@360.cn>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Message-Id: <1464179110-18593-1-git-send-email-ppandit@redhat.com>
Reviewed-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/scsi/megasas.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index bf642d4ff3..cc66d36186 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -650,7 +650,9 @@ static int megasas_init_firmware(MegasasState *s, MegasasCmd *cmd) pa_hi = le32_to_cpu(initq->pi_addr_hi); s->producer_pa = ((uint64_t) pa_hi << 32) | pa_lo; s->reply_queue_head = ldl_le_pci_dma(pcid, s->producer_pa); + s->reply_queue_head %= MEGASAS_MAX_FRAMES; s->reply_queue_tail = ldl_le_pci_dma(pcid, s->consumer_pa); + s->reply_queue_tail %= MEGASAS_MAX_FRAMES; flags = le32_to_cpu(initq->flags); if (flags & MFI_QUEUE_FLAG_CONTEXT64) { s->flags |= MEGASAS_MASK_USE_QUEUE64; |