summaryrefslogtreecommitdiffstats
path: root/hw
diff options
context:
space:
mode:
authorPrasad Joshi2014-03-24 16:44:46 +0100
committerPaolo Bonzini2014-03-26 13:19:22 +0100
commitec8929a55512606456e364ffa80586219f67c904 (patch)
treebf5206707c6969db073afd11b01c8949f055ce39 /hw
parentscsi: check req pointer before dereferencing it (diff)
downloadqemu-ec8929a55512606456e364ffa80586219f67c904.tar.gz
qemu-ec8929a55512606456e364ffa80586219f67c904.tar.xz
qemu-ec8929a55512606456e364ffa80586219f67c904.zip
spapr_vscsi: remove duplicate condition check
Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw')
-rw-r--r--hw/scsi/spapr_vscsi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c
index 34478f0157..d4ada4f335 100644
--- a/hw/scsi/spapr_vscsi.c
+++ b/hw/scsi/spapr_vscsi.c
@@ -690,7 +690,7 @@ static void vscsi_inquiry_no_target(VSCSIState *s, vscsi_req *req)
int rc, len, alen;
/* We dont do EVPD. Also check that page_code is 0 */
- if ((cdb[1] & 0x01) || (cdb[1] & 0x01) || cdb[2] != 0) {
+ if ((cdb[1] & 0x01) || cdb[2] != 0) {
/* Send INVALID FIELD IN CDB */
vscsi_makeup_sense(s, req, ILLEGAL_REQUEST, 0x24, 0);
vscsi_send_rsp(s, req, CHECK_CONDITION, 0, 0);