summaryrefslogtreecommitdiffstats
path: root/hw
diff options
context:
space:
mode:
authorKonrad Rzeszutek Wilk2015-06-29 18:30:37 +0200
committerStefano Stabellini2015-09-10 14:04:31 +0200
commitfaf5f56bf9f45ffc24a41fc8fc5ab76677aef688 (patch)
tree612de38a08d43e9ca48e1c314f357e331217e036 /hw
parentxen: use errno instead of rc for xc_domain_add_to_physmap (diff)
downloadqemu-faf5f56bf9f45ffc24a41fc8fc5ab76677aef688.tar.gz
qemu-faf5f56bf9f45ffc24a41fc8fc5ab76677aef688.tar.xz
qemu-faf5f56bf9f45ffc24a41fc8fc5ab76677aef688.zip
xen/pt/msi: Add the register value when printing logging and error messages
We would like to know what the MSI register value is to help in troubleshooting in the field. As such modify the logging logic to include such details in xen_pt_msgctrl_reg_write. Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Diffstat (limited to 'hw')
-rw-r--r--hw/xen/xen_pt_config_init.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c
index 9fb36704f8..56c84e115f 100644
--- a/hw/xen/xen_pt_config_init.c
+++ b/hw/xen/xen_pt_config_init.c
@@ -1102,7 +1102,7 @@ static int xen_pt_msgctrl_reg_write(XenPCIPassthroughState *s,
/* setup MSI pirq for the first time */
if (!msi->initialized) {
/* Init physical one */
- XEN_PT_LOG(&s->dev, "setup MSI\n");
+ XEN_PT_LOG(&s->dev, "setup MSI (register: %x).\n", *val);
if (xen_pt_msi_setup(s)) {
/* We do not broadcast the error to the framework code, so
* that MSI errors are contained in MSI emulation code and
@@ -1110,12 +1110,12 @@ static int xen_pt_msgctrl_reg_write(XenPCIPassthroughState *s,
* Guest MSI would be actually not working.
*/
*val &= ~PCI_MSI_FLAGS_ENABLE;
- XEN_PT_WARN(&s->dev, "Can not map MSI.\n");
+ XEN_PT_WARN(&s->dev, "Can not map MSI (register: %x)!\n", *val);
return 0;
}
if (xen_pt_msi_update(s)) {
*val &= ~PCI_MSI_FLAGS_ENABLE;
- XEN_PT_WARN(&s->dev, "Can not bind MSI\n");
+ XEN_PT_WARN(&s->dev, "Can not bind MSI (register: %x)!\n", *val);
return 0;
}
msi->initialized = true;