summaryrefslogtreecommitdiffstats
path: root/hw
diff options
context:
space:
mode:
authorJuan Quintela2020-11-18 09:37:42 +0100
committerMichael S. Tsirkin2020-12-08 19:48:58 +0100
commitfec037c1e2da0a7ea54eabce65cc14d461fdc5eb (patch)
tree21aec25c9fdf08509ed01e6d8533a3656aa21f27 /hw
parentfailover: simplify qdev_device_add() (diff)
downloadqemu-fec037c1e2da0a7ea54eabce65cc14d461fdc5eb.tar.gz
qemu-fec037c1e2da0a7ea54eabce65cc14d461fdc5eb.tar.xz
qemu-fec037c1e2da0a7ea54eabce65cc14d461fdc5eb.zip
failover: make sure that id always exist
We check that it exist at device creation time, so we don't have to check anywhere else. Signed-off-by: Juan Quintela <quintela@redhat.com> Message-Id: <20201118083748.1328-22-quintela@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw')
-rw-r--r--hw/net/virtio-net.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index ff82f1017d..c708c03cf6 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -3173,9 +3173,6 @@ static bool failover_hide_primary_device(DeviceListener *listener,
hide = qatomic_read(&n->failover_primary_hidden);
g_free(n->primary_device_id);
n->primary_device_id = g_strdup(device_opts->id);
- if (!n->primary_device_id) {
- warn_report("primary_device_id not set");
- }
return hide;
}