diff options
| author | Kevin Wolf | 2014-05-06 12:11:42 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi | 2014-05-09 20:57:31 +0200 |
| commit | b1e6fc0817dca14a3581d7b0979a5885608981f2 (patch) | |
| tree | 392958b989076df7e09dee397a50b4d327ce9ebf /include/block/block.h | |
| parent | qemu-iotests: Test converting to streamOptimized from small cluster size (diff) | |
| download | qemu-b1e6fc0817dca14a3581d7b0979a5885608981f2.tar.gz qemu-b1e6fc0817dca14a3581d7b0979a5885608981f2.tar.xz qemu-b1e6fc0817dca14a3581d7b0979a5885608981f2.zip | |
block: Fix open flags with BDRV_O_SNAPSHOT
The immediately visible effect of this patch is that it fixes committing
a temporary snapshot to its backing file. Previously, it would fail with
a "permission denied" error because bdrv_inherited_flags() forced the
backing file to be read-only, ignoring the r/w reopen of bdrv_commit().
The bigger problem this revealed is that the original open flags must
actually only be applied to the temporary snapshot, and the original
image file must be treated as a backing file of the temporary snapshot
and get the right flags for that.
Reported-by: Jan Kiszka <jan.kiszka@web.de>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'include/block/block.h')
| -rw-r--r-- | include/block/block.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/block/block.h b/include/block/block.h index 27d8598eec..1b119aac24 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -195,7 +195,7 @@ int bdrv_open_image(BlockDriverState **pbs, const char *filename, QDict *options, const char *bdref_key, int flags, bool allow_none, Error **errp); int bdrv_open_backing_file(BlockDriverState *bs, QDict *options, Error **errp); -void bdrv_append_temp_snapshot(BlockDriverState *bs, Error **errp); +void bdrv_append_temp_snapshot(BlockDriverState *bs, int flags, Error **errp); int bdrv_open(BlockDriverState **pbs, const char *filename, const char *reference, QDict *options, int flags, BlockDriver *drv, Error **errp); |