diff options
| author | Kevin Wolf | 2018-10-12 11:27:41 +0200 |
|---|---|---|
| committer | Kevin Wolf | 2018-11-05 15:09:55 +0100 |
| commit | eaa2410f1ea864609090c0a5fda9e0ce9499da79 (patch) | |
| tree | 68021063e0cf17887ba5cad0e7687dd485bd8ed5 /include/block/block.h | |
| parent | rbd: Close image in qemu_rbd_open() error path (diff) | |
| download | qemu-eaa2410f1ea864609090c0a5fda9e0ce9499da79.tar.gz qemu-eaa2410f1ea864609090c0a5fda9e0ce9499da79.tar.xz qemu-eaa2410f1ea864609090c0a5fda9e0ce9499da79.zip | |
block: Require auto-read-only for existing fallbacks
Some block drivers have traditionally changed their node to read-only
mode without asking the user. This behaviour has been marked deprecated
since 2.11, expecting users to provide an explicit read-only=on option.
Now that we have auto-read-only=on, enable these drivers to make use of
the option.
This is the only use of bdrv_set_read_only(), so we can make it a bit
more specific and turn it into a bdrv_apply_auto_read_only() that is
more convenient for drivers to use.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'include/block/block.h')
| -rw-r--r-- | include/block/block.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/block/block.h b/include/block/block.h index 580b3716c3..7f5453b45b 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -438,7 +438,8 @@ int bdrv_is_allocated_above(BlockDriverState *top, BlockDriverState *base, bool bdrv_is_read_only(BlockDriverState *bs); int bdrv_can_set_read_only(BlockDriverState *bs, bool read_only, bool ignore_allow_rdw, Error **errp); -int bdrv_set_read_only(BlockDriverState *bs, bool read_only, Error **errp); +int bdrv_apply_auto_read_only(BlockDriverState *bs, const char *errmsg, + Error **errp); bool bdrv_is_writable(BlockDriverState *bs); bool bdrv_is_sg(BlockDriverState *bs); bool bdrv_is_inserted(BlockDriverState *bs); |