diff options
| author | Vladimir Sementsov-Ogievskiy | 2019-06-06 17:41:32 +0200 |
|---|---|---|
| committer | Kevin Wolf | 2019-06-18 16:41:10 +0200 |
| commit | b23c580c946644b906af36e3f903b9fedd6ccd61 (patch) | |
| tree | fd1da098448077b498db94f12df9a1d3aa411b32 /include/block/block_int.h | |
| parent | blockdev: blockdev_mark_auto_del: drop usage of bs->job (diff) | |
| download | qemu-b23c580c946644b906af36e3f903b9fedd6ccd61.tar.gz qemu-b23c580c946644b906af36e3f903b9fedd6ccd61.tar.xz qemu-b23c580c946644b906af36e3f903b9fedd6ccd61.zip | |
block: drop bs->job
Drop remaining users of bs->job:
1. assertions actually duplicated by assert(!bs->refcnt)
2. trace-point seems not enough reason to change stream_start to return
BlockJob pointer
3. Restricting creation of two jobs based on same bs is bad idea, as
3.1 Some jobs creates filters to be their main node, so, this check
don't actually prevent creating second job on same real node (which
will create another filter node) (but I hope it is restricted by
other mechanisms)
3.2 Even without bs->job we have two systems of permissions:
op-blockers and BLK_PERM
3.3 We may want to run several jobs on one node one day
And finally, drop bs->job pointer itself. Hurrah!
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'include/block/block_int.h')
| -rw-r--r-- | include/block/block_int.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/include/block/block_int.h b/include/block/block_int.h index 8bb1cfb80a..a498c2670b 100644 --- a/include/block/block_int.h +++ b/include/block/block_int.h @@ -812,9 +812,6 @@ struct BlockDriverState { /* operation blockers */ QLIST_HEAD(, BdrvOpBlocker) op_blockers[BLOCK_OP_TYPE_MAX]; - /* long-running background operation */ - BlockJob *job; - /* The node that this node inherited default options from (and a reopen on * which can affect this node by changing these defaults). This is always a * parent node of this node. */ |