diff options
author | Vladimir Sementsov-Ogievskiy | 2020-12-11 19:39:31 +0100 |
---|---|---|
committer | Eric Blake | 2021-02-03 15:17:11 +0100 |
commit | 8b0c5d7659f0d0c192f78867f4dc6026e9f3506f (patch) | |
tree | adf9c78d77f5c6e41bf7b90720b3b086a904e557 /include/block | |
parent | block/io: support int64_t bytes in bdrv_co_do_copy_on_readv() (diff) | |
download | qemu-8b0c5d7659f0d0c192f78867f4dc6026e9f3506f.tar.gz qemu-8b0c5d7659f0d0c192f78867f4dc6026e9f3506f.tar.xz qemu-8b0c5d7659f0d0c192f78867f4dc6026e9f3506f.zip |
block/io: support int64_t bytes in bdrv_aligned_preadv()
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibility for signed return type (where negative value means
error).
So, prepare bdrv_aligned_preadv() now.
Make the bytes variable in bdrv_padding_rmw_read() int64_t, as it is
only used for pass-through to bdrv_aligned_preadv().
All bdrv_aligned_preadv() callers are safe as type is widening. Let's
look inside:
- add a new-style assertion that request is good.
- callees bdrv_is_allocated(), bdrv_co_do_copy_on_readv() supports
int64_t bytes
- conversion of bytes_remaining is OK, as we never have requests
overflowing BDRV_MAX_LENGTH
- looping through bytes_remaining is ok, num is updated to int64_t
- for bdrv_driver_preadv we have same limit of max_transfer
- qemu_iovec_memset is OK, as bytes+qiov_offset should not overflow
qiov->size anyway (thanks to bdrv_check_qiov_request())
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201211183934.169161-14-vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
[eblake: grammar tweak]
Signed-off-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'include/block')
0 files changed, 0 insertions, 0 deletions