diff options
| author | Stefan Hajnoczi | 2020-05-11 20:36:30 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi | 2020-05-18 19:16:00 +0200 |
| commit | ba607ca8bff4d2c2062902f8355657c865ac7c29 (patch) | |
| tree | de002f3ab22e267501feb4b691e51c22662b1753 /include/block | |
| parent | aio-posix: don't duplicate fd handler deletion in fdmon_io_uring_destroy() (diff) | |
| download | qemu-ba607ca8bff4d2c2062902f8355657c865ac7c29.tar.gz qemu-ba607ca8bff4d2c2062902f8355657c865ac7c29.tar.xz qemu-ba607ca8bff4d2c2062902f8355657c865ac7c29.zip | |
aio-posix: disable fdmon-io_uring when GSource is used
The glib event loop does not call fdmon_io_uring_wait() so fd handlers
waiting to be submitted build up in the list. There is no benefit is
using io_uring when the glib GSource is being used, so disable it
instead of implementing a more complex fix.
This fixes a memory leak where AioHandlers would build up and increasing
amounts of CPU time were spent iterating them in aio_pending(). The
symptom is that guests become slow when QEMU is built with io_uring
support.
Buglink: https://bugs.launchpad.net/qemu/+bug/1877716
Fixes: 73fd282e7b6dd4e4ea1c3bbb3d302c8db51e4ccf ("aio-posix: add io_uring fd monitoring implementation")
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Tested-by: Oleksandr Natalenko <oleksandr@redhat.com>
Message-id: 20200511183630.279750-3-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'include/block')
| -rw-r--r-- | include/block/aio.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/block/aio.h b/include/block/aio.h index 62ed954344..b2f703fa3f 100644 --- a/include/block/aio.h +++ b/include/block/aio.h @@ -701,6 +701,9 @@ void aio_context_setup(AioContext *ctx); */ void aio_context_destroy(AioContext *ctx); +/* Used internally, do not call outside AioContext code */ +void aio_context_use_g_source(AioContext *ctx); + /** * aio_context_set_poll_params: * @ctx: the aio context |