diff options
| author | Paolo Bonzini | 2017-05-08 16:13:06 +0200 |
|---|---|---|
| committer | Jeff Cody | 2017-05-24 22:38:51 +0200 |
| commit | 4c241cf5d6ca06c682e033cf8b327b63b1f4b784 (patch) | |
| tree | 693fb5c994e5d2e79ca45e25e0d1e9e8a8c2435c /include/exec/exec-all.h | |
| parent | blockjob: move iostatus reset inside block_job_user_resume (diff) | |
| download | qemu-4c241cf5d6ca06c682e033cf8b327b63b1f4b784.tar.gz qemu-4c241cf5d6ca06c682e033cf8b327b63b1f4b784.tar.xz qemu-4c241cf5d6ca06c682e033cf8b327b63b1f4b784.zip | |
blockjob: introduce block_job_cancel_async, check iostatus invariants
The new functions helps respecting the invariant that the coroutine
is entered with false user_resume, zero pause count and no error
recorded in the iostatus.
Resetting the iostatus is now common to all of block_job_cancel_async,
block_job_user_resume and block_job_iostatus_reset, albeit with slight
differences:
- block_job_cancel_async resets the iostatus, and resumes the job if
there was an error, but the coroutine is not restarted immediately.
For example the caller may continue with a call to block_job_finish_sync.
- block_job_user_resume resets the iostatus. It wants to resume the job
unconditionally, even if there was no error.
- block_job_iostatus_reset doesn't resume the job at all. Maybe that's
a bug but it should be fixed separately.
block_job_iostatus_reset does the least common denominator, so add some
checking but otherwise leave it as the entry point for resetting the
iostatus.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20170508141310.8674-8-pbonzini@redhat.com
Signed-off-by: Jeff Cody <jcody@redhat.com>
Diffstat (limited to 'include/exec/exec-all.h')
0 files changed, 0 insertions, 0 deletions