diff options
| author | Philippe Mathieu-Daudé | 2017-07-27 04:42:08 +0200 |
|---|---|---|
| committer | Michael Tokarev | 2017-07-31 12:06:38 +0200 |
| commit | b7b1e9dd6d56612d4656817b11e43d9fbefdc497 (patch) | |
| tree | cc9ab18d6dc43054a04634c88826393c81ddbbff /include/exec/memory.h | |
| parent | loader: check get_image_size() return value (diff) | |
| download | qemu-b7b1e9dd6d56612d4656817b11e43d9fbefdc497.tar.gz qemu-b7b1e9dd6d56612d4656817b11e43d9fbefdc497.tar.xz qemu-b7b1e9dd6d56612d4656817b11e43d9fbefdc497.zip | |
ivshmem: fix incorrect error handling in ivshmem_recv_msg()
Screwed up in commit 3a55fc0f, v2.6.0.
If qemu_chr_fe_read_all() returns -EINTR the do {} statement continues and the
n accumulator used to complete reads upto sizeof(msg) is decremented by 4 (the
value of EINTR on Linux).
To avoid that, use simpler if() statements and continue if EINTR occured.
hw/misc/ivshmem.c:650:14: warning: Loss of sign in implicit conversion
} while (n < sizeof(msg));
^
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'include/exec/memory.h')
0 files changed, 0 insertions, 0 deletions
