diff options
| author | Alex Bennée | 2021-02-13 14:03:22 +0100 |
|---|---|---|
| committer | Alex Bennée | 2021-02-18 09:19:23 +0100 |
| commit | cfd405eae6ad7a0e20b006e3295c5e8edab3ce3f (patch) | |
| tree | e65cff6041fc797b3ce6eaebe19547c046ff8e54 /include/exec/plugin-gen.h | |
| parent | accel/tcg: remove CF_NOCACHE and special cases (diff) | |
| download | qemu-cfd405eae6ad7a0e20b006e3295c5e8edab3ce3f.tar.gz qemu-cfd405eae6ad7a0e20b006e3295c5e8edab3ce3f.tar.xz qemu-cfd405eae6ad7a0e20b006e3295c5e8edab3ce3f.zip | |
accel/tcg: allow plugin instrumentation to be disable via cflags
When icount is enabled and we recompile an MMIO access we end up
double counting the instruction execution. To avoid this we introduce
the CF_MEMI cflag which only allows memory instrumentation for the
next TB (which won't yet have been counted). As this is part of the
hashed compile flags we will only execute the generated TB while
coming out of a cpu_io_recompile.
While we are at it delete the old TODO. We might as well keep the
translation handy as it's likely you will repeatedly hit it on each
MMIO access.
Reported-by: Aaron Lindsay <aaron@os.amperecomputing.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Aaron Lindsay <aaron@os.amperecomputing.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210213130325.14781-21-alex.bennee@linaro.org>
Diffstat (limited to 'include/exec/plugin-gen.h')
| -rw-r--r-- | include/exec/plugin-gen.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/exec/plugin-gen.h b/include/exec/plugin-gen.h index 4834a9e2f4..b1b72b5d90 100644 --- a/include/exec/plugin-gen.h +++ b/include/exec/plugin-gen.h @@ -19,7 +19,7 @@ struct DisasContextBase; #ifdef CONFIG_PLUGIN -bool plugin_gen_tb_start(CPUState *cpu, const TranslationBlock *tb); +bool plugin_gen_tb_start(CPUState *cpu, const TranslationBlock *tb, bool supress); void plugin_gen_tb_end(CPUState *cpu); void plugin_gen_insn_start(CPUState *cpu, const struct DisasContextBase *db); void plugin_gen_insn_end(void); @@ -41,7 +41,7 @@ static inline void plugin_insn_append(const void *from, size_t size) #else /* !CONFIG_PLUGIN */ static inline -bool plugin_gen_tb_start(CPUState *cpu, const TranslationBlock *tb) +bool plugin_gen_tb_start(CPUState *cpu, const TranslationBlock *tb, bool supress) { return false; } |