diff options
| author | Markus Armbruster | 2020-06-30 11:03:44 +0200 |
|---|---|---|
| committer | Markus Armbruster | 2020-07-02 06:25:29 +0200 |
| commit | 81f66cfd24ccd2645b19366d768a72f20ea3838b (patch) | |
| tree | c81a9c5321ed12787d4265413f03ac540270a794 /include/exec/user | |
| parent | riscv_hart: Fix riscv_harts_realize() error API violations (diff) | |
| download | qemu-81f66cfd24ccd2645b19366d768a72f20ea3838b.tar.gz qemu-81f66cfd24ccd2645b19366d768a72f20ea3838b.tar.xz qemu-81f66cfd24ccd2645b19366d768a72f20ea3838b.zip | |
mips/cps: Fix mips_cps_realize() error API violations
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
mips_cps_realize() is wrong that way: it passes &err to multiple
object_property_set_FOO() without checking for failure, and then to
sysbus_realize(). Harmless, because the object_property_set_FOO()
can't actually fail here.
Fix by passing &error_abort instead.
Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200630090351.1247703-20-armbru@redhat.com>
Diffstat (limited to 'include/exec/user')
0 files changed, 0 insertions, 0 deletions