diff options
| author | Stefan Hajnoczi | 2020-06-17 15:21:57 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi | 2020-06-23 16:46:08 +0200 |
| commit | 04b3fb39c815e6de67c5003e610d1cdecc911980 (patch) | |
| tree | a22cf62646ba060d29a58e8ab1bee6112ba41265 /include/exec | |
| parent | block/nvme: drop tautologous assertion (diff) | |
| download | qemu-04b3fb39c815e6de67c5003e610d1cdecc911980.tar.gz qemu-04b3fb39c815e6de67c5003e610d1cdecc911980.tar.xz qemu-04b3fb39c815e6de67c5003e610d1cdecc911980.zip | |
block/nvme: don't access CQE after moving cq.head
Do not access a CQE after incrementing q->cq.head and releasing q->lock.
It is unlikely that this causes problems in practice but it's a latent
bug.
The reason why it should be safe at the moment is that completion
processing is not re-entrant and the CQ doorbell isn't written until the
end of nvme_process_completion().
Make this change now because QEMU expects completion processing to be
re-entrant and later patches will do that.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Sergio Lopez <slp@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200617132201.1832152-4-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'include/exec')
0 files changed, 0 insertions, 0 deletions