summaryrefslogtreecommitdiffstats
path: root/include/exec
diff options
context:
space:
mode:
authorSameeh Jubran2018-10-23 13:23:13 +0200
committerMichael Roth2018-10-31 15:04:20 +0100
commit0d7f937e2a3ef6d80e8cb3d2cbca95f7365b451e (patch)
treef19608f3161aa9fe4d5958f1fbcdfb681b9a161b /include/exec
parentqga: linux: return disk device in guest-get-fsinfo (diff)
downloadqemu-0d7f937e2a3ef6d80e8cb3d2cbca95f7365b451e.tar.gz
qemu-0d7f937e2a3ef6d80e8cb3d2cbca95f7365b451e.tar.xz
qemu-0d7f937e2a3ef6d80e8cb3d2cbca95f7365b451e.zip
qga-win: prevent crash when executing fsinfo command
The fsinfo command is currently implemented for Windows only and it's disk parameter can be enabled by adding the define "CONFIG_QGA_NTDDSCSI" to the qga code. When enabled and executed the qemu-ga crashed with the following message: ------------------------------------------------ File qapi/qapi-visit-core.c, Line 49 Expression: !(v->type & VISITOR_OUTPUT) || *obj) ------------------------------------------------ After some digging, turns out that the GuestPCIAddress is null and the qapi visitor doesn't like that, so we can always allocate it instead and initiate all it's members to -1. Signed-off-by: Sameeh Jubran <sjubran@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com> Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Diffstat (limited to 'include/exec')
0 files changed, 0 insertions, 0 deletions