diff options
| author | Peter Maydell | 2018-10-16 19:09:38 +0200 |
|---|---|---|
| committer | Kevin Wolf | 2018-11-05 15:09:54 +0100 |
| commit | 1229e46d3cfe61ee0b11f08fbbc7530af1578637 (patch) | |
| tree | b28c252d9bb6bd1715cc3f7be68f275d792b5ad3 /include/exec | |
| parent | vpc: Don't leak opts in vpc_open() (diff) | |
| download | qemu-1229e46d3cfe61ee0b11f08fbbc7530af1578637.tar.gz qemu-1229e46d3cfe61ee0b11f08fbbc7530af1578637.tar.xz qemu-1229e46d3cfe61ee0b11f08fbbc7530af1578637.zip | |
block/vhdx: Don't take address of fields in packed structs
Taking the address of a field in a packed struct is a bad idea, because
it might not be actually aligned enough for that pointer type (and
thus cause a crash on dereference on some host architectures). Newer
versions of clang warn about this. Avoid the bug by not using the
"modify in place" byte swapping functions.
There are a few places where the in-place swap function is
used on something other than a packed struct field; we convert
those anyway, for consistency.
Patch produced with scripts/coccinelle/inplace-byteswaps.cocci.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'include/exec')
0 files changed, 0 insertions, 0 deletions