diff options
| author | Richard Henderson | 2020-01-24 00:22:47 +0100 |
|---|---|---|
| committer | Cornelia Huck | 2020-01-27 12:13:10 +0100 |
| commit | 344a7f656e8d211cdd6e248a0644612f386ef8ea (patch) | |
| tree | 9708695f34e8e6ce32b88f0b9da8776a163b6e60 /include/exec | |
| parent | target/s390x: Pass DisasContext to get_field and have_field (diff) | |
| download | qemu-344a7f656e8d211cdd6e248a0644612f386ef8ea.tar.gz qemu-344a7f656e8d211cdd6e248a0644612f386ef8ea.tar.xz qemu-344a7f656e8d211cdd6e248a0644612f386ef8ea.zip | |
target/s390x: Move DisasFields into DisasContext
I believe that the separate allocation of DisasFields from DisasContext
was meant to limit the places from which we could access fields. But
that plan did not go unchanged, and since DisasContext contains a pointer
to fields, the substructure is accessible everywhere.
By allocating the substructure with DisasContext, we improve the locality
of the accesses by avoiding one level of pointer chasing. In addition,
we avoid a dangling pointer to stack allocated memory, diagnosed by static
checkers.
Launchpad: https://bugs.launchpad.net/bugs/1661815
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200123232248.1800-5-richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Diffstat (limited to 'include/exec')
0 files changed, 0 insertions, 0 deletions