diff options
| author | Gonglei | 2016-02-19 08:33:58 +0100 |
|---|---|---|
| committer | Gerd Hoffmann | 2016-02-23 10:38:01 +0100 |
| commit | 5f77e06baa84323e5bbc96c2c7f4fe627078b210 (patch) | |
| tree | 14988e1e4f582f689658be931b4bc48f4bb69b81 /include/exec | |
| parent | usb: check RNDIS buffer offsets & length (diff) | |
| download | qemu-5f77e06baa84323e5bbc96c2c7f4fe627078b210.tar.gz qemu-5f77e06baa84323e5bbc96c2c7f4fe627078b210.tar.xz qemu-5f77e06baa84323e5bbc96c2c7f4fe627078b210.zip | |
usb: add pid check at the first of uhci_handle_td()
pid can be gotten from uhci device memory in uhci_handle_td(),
so the guest can trigger assert qemu if we get an invalid pid.
And the uhci spec 2.1.2 tells us The Host Controller sets Host
Controller Process Error bit to 1 when it detects a fatal error
and indicates that the Host Controller suffered a consistency
check failure while processing a Transfer Descriptor. An example
of a consistency check failure would be finding an illegal PID
field while processing the packet header portion of the TD.
When this error occurs, the Host Controller clears the Run/Stop
bit in the Command register to prevent further schedule execution.
We'd better to set UHCI_STS_HCPERR and kick an interrupt, check
the pid value at the first of uhci_handle_td function.
https://bugzilla.redhat.com/show_bug.cgi?id=1070027
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Message-id: 1455867238-4720-1-git-send-email-arei.gonglei@huawei.com
[ applied minor codestyle fix ]
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'include/exec')
0 files changed, 0 insertions, 0 deletions
