diff options
| author | Prasad J Pandit | 2020-05-26 13:17:43 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2020-06-10 18:10:50 +0200 |
| commit | 77f55eac6c433e23e82a1b88b2d74f385c4c7d82 (patch) | |
| tree | f0a31aa10d21136397cee350fe1c56006a5d20f3 /include/exec | |
| parent | configure: Do not ignore malloc value (diff) | |
| download | qemu-77f55eac6c433e23e82a1b88b2d74f385c4c7d82.tar.gz qemu-77f55eac6c433e23e82a1b88b2d74f385c4c7d82.tar.xz qemu-77f55eac6c433e23e82a1b88b2d74f385c4c7d82.zip | |
exec: set map length to zero when returning NULL
When mapping physical memory into host's virtual address space,
'address_space_map' may return NULL if BounceBuffer is in_use.
Set and return '*plen = 0' to avoid later NULL pointer dereference.
Reported-by: Alexander Bulekov <alxndr@bu.edu>
Fixes: https://bugs.launchpad.net/qemu/+bug/1878259
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Message-Id: <20200526111743.428367-1-ppandit@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'include/exec')
| -rw-r--r-- | include/exec/memory.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/exec/memory.h b/include/exec/memory.h index bd7fdd6081..af8ca7824e 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -2314,7 +2314,8 @@ bool address_space_access_valid(AddressSpace *as, hwaddr addr, hwaddr len, /* address_space_map: map a physical memory region into a host virtual address * * May map a subset of the requested range, given by and returned in @plen. - * May return %NULL if resources needed to perform the mapping are exhausted. + * May return %NULL and set *@plen to zero(0), if resources needed to perform + * the mapping are exhausted. * Use only for reads OR writes - not for read-modify-write operations. * Use cpu_register_map_client() to know when retrying the map operation is * likely to succeed. |